Skip to content

feat(api): Avoid deprecated fields#463

Merged
JR-Morgan merged 11 commits into
mainfrom
jrm/avoid-deprecated-fields
Jun 30, 2026
Merged

feat(api): Avoid deprecated fields#463
JR-Morgan merged 11 commits into
mainfrom
jrm/avoid-deprecated-fields

Conversation

@JR-Morgan

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecov Bot commented Mar 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.59%. Comparing base (f529b91) to head (ff8e82d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #463      +/-   ##
==========================================
+ Coverage   73.57%   73.59%   +0.02%     
==========================================
  Files         367      367              
  Lines       14775    14784       +9     
  Branches     1223     1223              
==========================================
+ Hits        10871    10881      +10     
  Misses       3496     3496              
+ Partials      408      407       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JR-Morgan JR-Morgan marked this pull request as draft March 24, 2026 09:36
@JR-Morgan

Copy link
Copy Markdown
Member Author

We have a bit of a problem here... workspace.logo is deprecated on app in favour of workspace.logoUrl...
but the public server doesn't have workspace.logoUrl...

either, this will necessitate clients doing some magic... or we hold off until we have a different solution for public servers...

@JR-Morgan JR-Morgan changed the title Avoid deprecated fields feat(api): Avoid deprecated fields Mar 24, 2026
@JR-Morgan JR-Morgan marked this pull request as ready for review June 30, 2026 10:41
@JR-Morgan JR-Morgan requested a review from danielgak June 30, 2026 10:42
@JR-Morgan JR-Morgan enabled auto-merge (squash) June 30, 2026 10:42
@JR-Morgan JR-Morgan merged commit 3fddcc3 into main Jun 30, 2026
6 checks passed
@JR-Morgan JR-Morgan deleted the jrm/avoid-deprecated-fields branch June 30, 2026 10:42
oguzhankoral added a commit that referenced this pull request Jul 1, 2026
The workspace GraphQL queries (WorkspaceResource, ActiveUserResource) request `logoUrl`
and the server returns it, but the merged-in LimitedWorkspace model named the member
`logoUri` (#463) — so deserialization failed: "Could not find member 'logoUrl' on object
of type 'Workspace'". Rename the model member to logoUrl to match the server field the
queries actually request.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants